#592 celu selu gelu

Merged

zoulq merged 10 commits from lzh/MSAdapter:opt_0703 into master 10 months ago

lzh changed title from ~~celu selu gelu~~ to [WIP]celu selu gelu 10 months ago

lzh changed title from ~~[WIP]celu selu gelu~~ to celu selu gelu 10 months ago

frelam reviewed 10 months ago

SupportedList_en.md

												
			@@ -885,2 +884,3 @@
		
			| nn.CELU | Partly supported | inplace not support on GRAPH mode |  
		
			| nn.SELU | Partly supported | [Function is constrained](ConstraintList_en.md) |
		
			| nn.CELU | Partly supported | [Function is constrained](ConstraintList_en.md) |
		
			| nn.GELU | Supported | |

frelam commented 10 months ago

nn.GELU当前缺少approximate参数, 而且当前调用的是ms.ops.GELU, 该算子只是满足计算approximiate为tanh的场景。需要改为调用ms.ops.gelu

lzh commented 10 months ago

大写的GELU SELU CELU不在这个pr的整改范围，这里误改了，现在先改回去了。

frelam reviewed 10 months ago

ConstraintList.md

frelam reviewed 10 months ago

testing/ut/pytorch/nn/test_init.py

frelam reviewed 10 months ago

testing/ut/pytorch/nn/functional/test_pdist.py

zoulq referenced this issue from a commit 10 months ago

celu selu gelu (#592) fix SELU CELU supportlist errors remove key-value assignment constraint in the list use param_compare in normalize use param_compare in one_ht use param_compare in pdist add grid_sample positional args testcase improve grid_sample and testcases nn init funcs testcases improvement update supportlist improve celu selu gelu for cpu Co-authored-by: liuzehui2023 <liuzehui3@huawei.com> Reviewed-on: https://openi.pcl.ac.cn/OpenI/MSAdapter/pulls/592

zoulq merged commit 112dae0f60 into master 10 months ago

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

@@ -250,1 +250,4 @@
 | functional.mish | 1.`inplace`不支持图模式；2.不支持float64 |
 | functional.selu | `inplace`不支持图模式 |
 | functional.celu | 1.`inplace`不支持图模式；2.不支持float64 |
 | functional.grid_sample | 1.图模式下不支持等号赋值关键字参数。2.不支持`mode='bicubic'` |

@@ -10,3 +10,3 @@
 def test_dirac_():
     t_w1 = torch.empty(3, 16, 5, 5)
     t_w1 = torch.empty(3, 16, 5, 5, dtype=torch.float64)

@@ -26,3 +25,3 @@
 def test_pdist2():
     data = np.arange(0, 12).reshape(4, 3).astype(np.float32)
     data = np.arange(0, 12).reshape(4, 3).astype(np.float64)