关于GCU、沐曦GPGPU、MLU、0卡V100资源4月7日恢复上架的公告>>> 关于共建具身智能开源数据集的倡议>>> 关于云脑任务中统一路径访问方式的公告>>> 关于将启智集群GPU资源迁移至智算集群的公告>>>
OpenI
/
MSAdapter
Not watched
19
40
Fork 65
Code
Releases 6 Wiki Activity
Issues 1 Pull Requests 8 Datasets Model Cloudbrain
Pull Requests
/
Detail
Labels Milestones
New Pull Request

#516 update torchaudio and fix dataloader init

Merged
Erpim merged 23 commits from torchaudio into master 1 year ago
Conversation 0 Commits 23 Files Changed 8
hanjr commented 1 year ago
Erpim reviewed 1 year ago
msadapter/pytorch/utils/data/_utils/collate.py
@@ -331,2 +331,3 @@
raise TypeError(default_collate_err_msg_format.format(elem_type))
raise TypeError(default_collate_err_msg_format.format(elem_type))

Erpim commented 1 year ago

直接做累加？不用返回list再加了吧？

直接做累加？不用返回list再加了吧？
Erpim reviewed 1 year ago
msadapter/pytorch/utils/data/_utils/collate.py
@@ -333,0 +338,4 @@
for i in data:
collate_nbytes(i, return_list)
elif isinstance(data, collections.abc.Mapping):
for key in data:
Erpim commented 1 year ago

collate_nbytes(data[key], return_list)

collate_nbytes(data[key], return_list)
hanjr marked this conversation as resolved
Erpim reviewed 1 year ago
msadapter/pytorch/utils/data/dataloader.py
@@ -380,0 +395,4 @@
collate_nbytes(single_data, nbytes)
del temp_dataloaderiter
del single_data
nbytes = int((sum(nbytes) >> 20) * 1.2)
Erpim commented 1 year ago

魔鬼数字，注释下为什么是1.2，建议新建个变量，可以叫relaxation ratio之类的。

魔鬼数字，注释下为什么是1.2，建议新建个变量，可以叫relaxation ratio之类的。
Erpim reviewed 1 year ago
msadapter/pytorch/utils/data/dataloader.py
@@ -380,0 +399,4 @@
self.maxsize = MIN_POWER_TWO(nbytes)
else:
self.maxsize = 128

Erpim commented 1 year ago

初始化的时候就创建迭代器对象

初始化的时候就创建迭代器对象
Erpim reviewed 1 year ago
msadapter/torchaudio/backend/sox_io_backend.py
@@ -8,3 +1,1 @@
# from .common import AudioMetaData
#
#

Erpim commented 1 year ago

多余空行

多余空行
hanjr marked this conversation as resolved
Erpim merged commit 2416936c7b into master 1 year ago
The pull request has been merged as 2416936c7b.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'torchaudio'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes
Please read the following content carefully:

Dear OpenI User

Thank you for your continuous support to the Openl Qizhi Community AI Collaboration Platform. In order to protect your usage rights and ensure network security, we updated the Openl Qizhi Community AI Collaboration Platform Usage Agreement in January 2024. The updated agreement specifies that users are prohibited from using intranet penetration tools. After you click "Agree and continue", you can continue to use our services. Thank you for your cooperation and understanding.

For more agreement content, please refer to the《Openl Qizhi Community AI Collaboration Platform Usage Agreement》

Agree and continue
Disagree, exit