#794 update size

Merged
zoulq merged 1 commits from erpim_1128_ into master 1 year ago
Erpim commented 1 year ago
Erpim changed title from [WIP]update size to update size 1 year ago
Erpim commented 1 year ago
Poster
代码合入后PyNative下size相关问题可解决,图模式下现象和当前一致(部分场景异常),框架侧适配后可完全解决(2.3前解决)
zoulq reviewed 1 year ago
testing/ut/pytorch/tensor/test_size.py
@@ -0,0 +22,4 @@
ms_tensor_1 = ms_torch.Tensor(2, 3, 4)
torch_tensor_1 = torch.Tensor(2, 3, 4)

assert ms_tensor_1.size().numel() == torch_tensor_1.size().numel()
zoulq commented 1 year ago
Size下的方法是否支持在图模式下使用? 用例可以写成pynative和图模式共用的代码,图模式不支持skip掉,既能明显看出功能支持范围,也能节省ci中graph执行时间
Erpim commented 1 year ago
暂不支持图模式,已将后面部分用例改造成图模式用例执行,当前先skip
zoulq reviewed 1 year ago
testing/ut/pytorch/tensor/test_size.py
@@ -0,0 +46,4 @@
msa_net = TestNet(size_func)
ms_tensor = ms_torch.Tensor(2, 3)
output = msa_net(ms_tensor)
assert str(output.size()) == "mindtorch.Size([2, 3])"
zoulq commented 1 year ago
这个输出“mindtorch.Size”感觉不合适
Erpim commented 1 year ago
torch 输出的是torch.Size
Erpim commented 1 year ago
torch.Size([2, 3])
zoulq reviewed 1 year ago
@@ -291,6 +292,8 @@ class Tensor(StubTensor, metaclass=_TensorMeta):
if len(data) == 1:
if isinstance(data[0], (int, np.integer)):
_shape = data
elif isinstance(data[0], Size):
zoulq commented 1 year ago
这个加入之后,会不会影响非size输入的图模式功能?
Erpim commented 1 year ago
不会,这个添加后,图模式也是正常执行的,只是当成了tuple,导致结果不符合预期,理论上不影响其他场景
zoulq merged commit ed079aba0e into master 1 year ago
The pull request has been merged as ed079aba0e.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.