OpenI
/
MSAdapter
Not watched
20
45
Fork 75
Code
Releases 7 Wiki Activity
Issues 7 Pull Requests 8 Datasets Model Cloudbrain
Pull Requests
/
Detail
Labels Milestones
New Pull Request

#785 [0.2]searchsorted value support scalar，meitu sd support syntax

Merged
zoulq merged 1 commits from 543145646twc/MSAdapter:develop-twc-release_0.2 into release_0.2 1 year ago
Conversation 5 Commits 1 Files Changed 13
zoulq changed title from searchsorted value support scalar to [0.2]searchsorted value support scalar 1 year ago
zoulq commented 1 year ago
Collaborator

CI失败原因： FAILED testing/ut/pytorch/functional/test_math.py::test_searchsorted_scalar - AssertionError

CI失败原因： FAILED testing/ut/pytorch/functional/test_math.py::test_searchsorted_scalar - AssertionError
543145646twc changed title from [0.2]searchsorted value support scalar to [0.2]searchsorted value support scalar，meitu sd support syntax 1 year ago
frelam commented 1 year ago
Collaborator

************* Module mindtorch.torch._utils
mindtorch/torch/_utils.py:127:0: C0304: Final newline missing (missing-final-newline)
mindtorch/torch/_utils.py:117:0: R1711: Useless return at end of function or method (useless-return)
mindtorch/torch/_utils.py:117:27: W0613: Unused argument 'tensors' (unused-argument)
mindtorch/torch/_utils.py:121:0: R1711: Useless return at end of function or method (useless-return)
mindtorch/torch/_utils.py:121:18: W0613: Unused argument 'tensors' (unused-argument)
mindtorch/torch/_utils.py:121:27: W0613: Unused argument 'size_limit' (unused-argument)
mindtorch/torch/_utils.py:125:0: R1711: Useless return at end of function or method (useless-return)
mindtorch/torch/_utils.py:125:29: W0613: Unused argument 'flat' (unused-argument)
mindtorch/torch/_utils.py:125:35: W0613: Unused argument 'tensors' (unused-argument)
************* Module mindtorch.torch.tensor_type
mindtorch/torch/tensor_type.py:6:23: W0613: Unused argument 'dim' (unused-argument)
************* Module mindtorch.torch.utils.cpp_extension
mindtorch/torch/utils/cpp_extension.py:17:0: C0304: Final newline missing (missing-final-newline)
mindtorch/torch/utils/cpp_extension.py:9:17: W0613: Unused argument 'self' (unused-argument)
mindtorch/torch/utils/cpp_extension.py:8:17: W0613: Unused argument 'name' (unused-argument)
mindtorch/torch/utils/cpp_extension.py:8:23: W0613: Unused argument 'sources' (unused-argument)
mindtorch/torch/utils/cpp_extension.py:8:0: W0613: Unused argument 'args' (unused-argument)
mindtorch/torch/utils/cpp_extension.py:8:0: W0613: Unused argument 'kwargs' (unused-argument)
mindtorch/torch/utils/cpp_extension.py:9:4: W0612: Unused variable 'init' (unused-variable)
mindtorch/torch/utils/cpp_extension.py:15:17: W0613: Unused argument 'self' (unused-argument)
mindtorch/torch/utils/cpp_extension.py:14:18: W0613: Unused argument 'name' (unused-argument)
mindtorch/torch/utils/cpp_extension.py:14:24: W0613: Unused argument 'sources' (unused-argument)
mindtorch/torch/utils/cpp_extension.py:14:0: W0613: Unused argument 'args' (unused-argument)
mindtorch/torch/utils/cpp_extension.py:14:0: W0613: Unused argument 'kwargs' (unused-argument)
mindtorch/torch/utils/cpp_extension.py:15:4: W0612: Unused variable 'init' (unused-variable)
************* Module mindtorch.torch.jit.init
mindtorch/torch/jit/init.py:42:0: C0304: Final newline missing (missing-final-newline)
************* Module mindtorch.torch.nn.modules.conv
mindtorch/torch/nn/modules/conv.py:622:0: C0304: Final newline missing (missing-final-newline)
mindtorch/torch/nn/modules/conv.py:622:8: W0101: Unreachable code (unreachable)
************* Module mindtorch.torch.nn.parallel.data_parallel
mindtorch/torch/nn/parallel/data_parallel.py:8:0: C0304: Final newline missing (missing-final-newline)
mindtorch/torch/nn/parallel/data_parallel.py:6:23: W0613: Unused argument 'module' (unused-argument)
mindtorch/torch/nn/parallel/data_parallel.py:6:31: W0613: Unused argument 'device_ids' (unused-argument)
mindtorch/torch/nn/parallel/data_parallel.py:6:48: W0613: Unused argument 'output_device' (unused-argument)
mindtorch/torch/nn/parallel/data_parallel.py:6:68: W0613: Unused argument 'dim' (unused-argument)
************* Module mindtorch.torch.nn.parallel.distributed
mindtorch/torch/nn/parallel/distributed.py:83:0: C0304: Final newline missing (missing-final-newline)
mindtorch/torch/nn/parallel/distributed.py:81:18: W0613: Unused argument 'obj' (unused-argument)
************* Module mindtorch.torch.nn.parallel._functions
mindtorch/torch/nn/parallel/_functions.py:14:0: C0304: Final newline missing (missing-final-newline)
mindtorch/torch/nn/parallel/_functions.py:11:0: R1711: Useless return at end of function or method (useless-return)
mindtorch/torch/nn/parallel/_functions.py:11:16: W0613: Unused argument 'device' (unused-argument)
mindtorch/torch/nn/parallel/_functions.py:3:0: W0611: Unused Module imported from mindtorch.torch.nn.modules.module (unused-import)

************* Module mindtorch.torch._utils mindtorch/torch/_utils.py:127:0: C0304: Final newline missing (missing-final-newline) mindtorch/torch/_utils.py:117:0: R1711: Useless return at end of function or method (useless-return) mindtorch/torch/_utils.py:117:27: W0613: Unused argument 'tensors' (unused-argument) mindtorch/torch/_utils.py:121:0: R1711: Useless return at end of function or method (useless-return) mindtorch/torch/_utils.py:121:18: W0613: Unused argument 'tensors' (unused-argument) mindtorch/torch/_utils.py:121:27: W0613: Unused argument 'size_limit' (unused-argument) mindtorch/torch/_utils.py:125:0: R1711: Useless return at end of function or method (useless-return) mindtorch/torch/_utils.py:125:29: W0613: Unused argument 'flat' (unused-argument) mindtorch/torch/_utils.py:125:35: W0613: Unused argument 'tensors' (unused-argument) ************* Module mindtorch.torch.tensor_type mindtorch/torch/tensor_type.py:6:23: W0613: Unused argument 'dim' (unused-argument) ************* Module mindtorch.torch.utils.cpp_extension mindtorch/torch/utils/cpp_extension.py:17:0: C0304: Final newline missing (missing-final-newline) mindtorch/torch/utils/cpp_extension.py:9:17: W0613: Unused argument 'self' (unused-argument) mindtorch/torch/utils/cpp_extension.py:8:17: W0613: Unused argument 'name' (unused-argument) mindtorch/torch/utils/cpp_extension.py:8:23: W0613: Unused argument 'sources' (unused-argument) mindtorch/torch/utils/cpp_extension.py:8:0: W0613: Unused argument 'args' (unused-argument) mindtorch/torch/utils/cpp_extension.py:8:0: W0613: Unused argument 'kwargs' (unused-argument) mindtorch/torch/utils/cpp_extension.py:9:4: W0612: Unused variable '__init__' (unused-variable) mindtorch/torch/utils/cpp_extension.py:15:17: W0613: Unused argument 'self' (unused-argument) mindtorch/torch/utils/cpp_extension.py:14:18: W0613: Unused argument 'name' (unused-argument) mindtorch/torch/utils/cpp_extension.py:14:24: W0613: Unused argument 'sources' (unused-argument) mindtorch/torch/utils/cpp_extension.py:14:0: W0613: Unused argument 'args' (unused-argument) mindtorch/torch/utils/cpp_extension.py:14:0: W0613: Unused argument 'kwargs' (unused-argument) mindtorch/torch/utils/cpp_extension.py:15:4: W0612: Unused variable '__init__' (unused-variable) ************* Module mindtorch.torch.jit.__init__ mindtorch/torch/jit/__init__.py:42:0: C0304: Final newline missing (missing-final-newline) ************* Module mindtorch.torch.nn.modules.conv mindtorch/torch/nn/modules/conv.py:622:0: C0304: Final newline missing (missing-final-newline) mindtorch/torch/nn/modules/conv.py:622:8: W0101: Unreachable code (unreachable) ************* Module mindtorch.torch.nn.parallel.data_parallel mindtorch/torch/nn/parallel/data_parallel.py:8:0: C0304: Final newline missing (missing-final-newline) mindtorch/torch/nn/parallel/data_parallel.py:6:23: W0613: Unused argument 'module' (unused-argument) mindtorch/torch/nn/parallel/data_parallel.py:6:31: W0613: Unused argument 'device_ids' (unused-argument) mindtorch/torch/nn/parallel/data_parallel.py:6:48: W0613: Unused argument 'output_device' (unused-argument) mindtorch/torch/nn/parallel/data_parallel.py:6:68: W0613: Unused argument 'dim' (unused-argument) ************* Module mindtorch.torch.nn.parallel.distributed mindtorch/torch/nn/parallel/distributed.py:83:0: C0304: Final newline missing (missing-final-newline) mindtorch/torch/nn/parallel/distributed.py:81:18: W0613: Unused argument 'obj' (unused-argument) ************* Module mindtorch.torch.nn.parallel._functions mindtorch/torch/nn/parallel/_functions.py:14:0: C0304: Final newline missing (missing-final-newline) mindtorch/torch/nn/parallel/_functions.py:11:0: R1711: Useless return at end of function or method (useless-return) mindtorch/torch/nn/parallel/_functions.py:11:16: W0613: Unused argument 'device' (unused-argument) mindtorch/torch/nn/parallel/_functions.py:3:0: W0611: Unused Module imported from mindtorch.torch.nn.modules.module (unused-import)
frelam commented 1 year ago
Collaborator

pylint check is starting.
************* Module mindtorch.torch._utils
mindtorch/torch/_utils.py:120:4: W0107: Unnecessary pass statement (unnecessary-pass)
mindtorch/torch/_utils.py:126:4: W0107: Unnecessary pass statement (unnecessary-pass)
mindtorch/torch/_utils.py:132:4: W0107: Unnecessary pass statement (unnecessary-pass)
************* Module mindtorch.torch.utils.cpp_extension
mindtorch/torch/utils/cpp_extension.py:12:4: W0107: Unnecessary pass statement (unnecessary-pass)
mindtorch/torch/utils/cpp_extension.py:19:4: W0107: Unnecessary pass statement (unnecessary-pass)
************* Module mindtorch.torch.autograd
mindtorch/torch/autograd/init.py:7:0: E0401: Unable to import 'mindtorch.torch.autograd.profiler' (import-error)
************* Module mindtorch.torch.nn.parallel.distributed
mindtorch/torch/nn/parallel/distributed.py:84:4: W0107: Unnecessary pass statement (unnecessary-pass)
************* Module mindtorch.torch.nn.parallel._functions
mindtorch/torch/nn/parallel/_functions.py:14:4: W0107: Unnecessary pass statement (unnecessary-pass)

pylint check is starting. ************* Module mindtorch.torch._utils mindtorch/torch/_utils.py:120:4: W0107: Unnecessary pass statement (unnecessary-pass) mindtorch/torch/_utils.py:126:4: W0107: Unnecessary pass statement (unnecessary-pass) mindtorch/torch/_utils.py:132:4: W0107: Unnecessary pass statement (unnecessary-pass) ************* Module mindtorch.torch.utils.cpp_extension mindtorch/torch/utils/cpp_extension.py:12:4: W0107: Unnecessary pass statement (unnecessary-pass) mindtorch/torch/utils/cpp_extension.py:19:4: W0107: Unnecessary pass statement (unnecessary-pass) ************* Module mindtorch.torch.autograd mindtorch/torch/autograd/__init__.py:7:0: E0401: Unable to import 'mindtorch.torch.autograd.profiler' (import-error) ************* Module mindtorch.torch.nn.parallel.distributed mindtorch/torch/nn/parallel/distributed.py:84:4: W0107: Unnecessary pass statement (unnecessary-pass) ************* Module mindtorch.torch.nn.parallel._functions mindtorch/torch/nn/parallel/_functions.py:14:4: W0107: Unnecessary pass statement (unnecessary-pass)
frelam commented 1 year ago
Collaborator

___________ ERROR collecting testing/ut/pytorch/torch/test_randn.py ____________
ImportError while importing test module '/drone/src/testing/ut/pytorch/torch/test_randn.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/python-3.7.5/lib/python3.7/importlib/init.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
testing/ut/pytorch/torch/test_randn.py:5: in
import mindtorch.torch as ms_torch
/usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/init.py:4: in
from mindtorch import torch
/usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/torch/init.py:5: in
from mindtorch.torch._register import *
/usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/torch/_register/init.py:8: in
from mindtorch.torch.nn import Parameter
/usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/torch/nn/init.py:9: in
from . import parallel
/usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/torch/nn/parallel/init.py:2: in
from .data_parallel import DataParallel
/usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/torch/nn/parallel/data_parallel.py in
from mindtorch import unsupported_attr
E ImportError: cannot import name 'unsupported_attr' from 'mindtorch' (/usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/init.py)

___________ ERROR collecting testing/ut/pytorch/torch/test_randn.py ____________ ImportError while importing test module '/drone/src/testing/ut/pytorch/torch/test_randn.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: /usr/local/python-3.7.5/lib/python3.7/importlib/__init__.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) testing/ut/pytorch/torch/test_randn.py:5: in <module> import mindtorch.torch as ms_torch /usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/__init__.py:4: in <module> from mindtorch import torch /usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/torch/__init__.py:5: in <module> from mindtorch.torch._register import * /usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/torch/_register/__init__.py:8: in <module> from mindtorch.torch.nn import Parameter /usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/torch/nn/__init__.py:9: in <module> from . import parallel /usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/torch/nn/parallel/__init__.py:2: in <module> from .data_parallel import DataParallel /usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/torch/nn/parallel/data_parallel.py:1: in <module> from mindtorch import unsupported_attr E ImportError: cannot import name 'unsupported_attr' from 'mindtorch' (/usr/local/python-3.7.5/lib/python3.7/site-packages/mindtorch-0.2.0-py3.7.egg/mindtorch/__init__.py)
zoulq reviewed 1 year ago
mindtorch/torch/_utils.py
@@ -116,0 +116,4 @@

def _flatten_dense_tensors(tensors):
unsupported_attr(tensors)
warning("`_flatten_dense_tensors is not implemented now.")
zoulq commented 1 year ago

除了warining打印，要有返回值，不然用户调用会报下一个算子的输入为nonetype错误，看一下是否能实现tensors的flatten结果，或者返回原始输入

除了warining打印，要有返回值，不然用户调用会报下一个算子的输入为nonetype错误，看一下是否能实现tensors的flatten结果，或者返回原始输入
zoulq reviewed 1 year ago
mindtorch/torch/_utils.py
@@ -116,0 +126,4 @@
def _unflatten_dense_tensors(flat, tensors):
unsupported_attr(flat)
unsupported_attr(tensors)
warning("`_unflatten_dense_tensors is not implemented now.")
zoulq commented 1 year ago

这几个接口是稀疏相关的，理论上用户代码中无法使用对应功能，如果只是import使用，建议这几个接口里直接raise error。现在用warning，但没有返回值，容易引入其他报错。

这几个接口是稀疏相关的，理论上用户代码中无法使用对应功能，如果只是import使用，建议这几个接口里直接raise error。现在用warning，但没有返回值，容易引入其他报错。
zoulq reviewed 1 year ago
mindtorch/torch/nn/parallel/_functions.py
@@ -0,0 +6,4 @@
class Scatter(Function):
def __init__(self):
super().__init__()
warning("`Scatter is not implemented now.")
zoulq commented 1 year ago

warning默认情况不会打印出来，这里可以直接raise error，然后提示用户可以自定义实现

warning默认情况不会打印出来，这里可以直接raise error，然后提示用户可以自定义实现
zoulq reviewed 1 year ago
mindtorch/torch/nn/parallel/data_parallel.py
@@ -0,0 +10,4 @@
unsupported_attr(device_ids)
unsupported_attr(output_device)
unsupported_attr(dim)
warning("`DataParallel is not implemented now.")
zoulq commented 1 year ago

同上，建议直接raise error

同上，建议直接raise error
543145646twc commented 1 year ago
Poster

全部空接口已经添加NotImplementedError快速报错

全部空接口已经添加NotImplementedError快速报错
zoulq merged commit eb75cc5bcc into release_0.2 1 year ago
The pull request has been merged as eb75cc5bcc.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '543145646twc/MSAdapter:develop-twc-release_0.2'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes
Please read the following content carefully:

Dear OpenI User

Thank you for your continuous support to the Openl Qizhi Community AI Collaboration Platform. In order to protect your usage rights and ensure network security, we updated the Openl Qizhi Community AI Collaboration Platform Usage Agreement in January 2024. The updated agreement specifies that users are prohibited from using intranet penetration tools. After you click "Agree and continue", you can continue to use our services. Thank you for your cooperation and understanding.

For more agreement content, please refer to the《Openl Qizhi Community AI Collaboration Platform Usage Agreement》

Agree and continue
Disagree, exit