#426 changes to Tensor.sum

Merged

Erpim merged 4 commits from lzh_sum into master 1 year ago

lzh reviewed 1 year ago

test

Erpim reviewed 1 year ago

msadapter/pytorch/tensor.py

lzh reviewed 1 year ago

msadapter/pytorch/tensor.py

lzh commented 1 year ago

已修改

lzh reviewed 1 year ago

msadapter/pytorch/tensor.py

												
			@@ -869,3 +869,2 @@
		
			        if dtype is not None:
		
			            input = input.astype(dtype) if dtype != mstype.bool_ else input.astype(mstype.int32)
		
			        elif self.dtype in msdapter_dtype.all_int_type:
		
			            input = input.astype(dtype) if dtype != mstype.bool_ else input.astype(mstype.bool_).astype(mstype.int64)

lzh commented 1 year ago

tensor([-1,1])，sum(dtype=bool)的情况，torch会把-1和1当作bool型处理，结果为True。ms.ops.sum不能处理bool型，如果先转换为int型，-1和1的sum为0，结果会返回False，所以需要先转换成bool再转int。

Erpim referenced this issue from a commit 1 year ago

changes to Tensor.sum (#426) fix bug when dtype==bool fix review issue minor changes add bool condition Co-authored-by: liuzehui2018 <liuzehui2009@gmail.com> Reviewed-on: https://openi.pcl.ac.cn/OpenI/MSAdapter/pulls/426

Erpim merged commit c54396b64e into master 1 year ago

lzh deleted branch lzh_sum 1 year ago

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

@@ -854,2 +854,2 @@
             input = input.astype(dtype) if dtype != mstype.bool_ else input.astype(mstype.int32)
         elif self.dtype in msdapter_dtype.all_int_type:
             input = input.astype(dtype) if dtype != mstype.bool_ else input.astype(mstype.int64)
         elif input.dtype in (msdapter_dtype.all_int_type, mstype.bool_):